New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[codemod] Add v5 important migration #27032
Conversation
They are removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR on the store. I'm taking it from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I scanned all files, I could not spot anything suspicious. I would say we could merge it and ask people to try it and collect some feedback. Good job @siriwatknp
Summary
unit tests increase from 45 to 125 π
The main transform is
preset-migration
that combine most of the transformers in folderv5.0.0
.The plan is to let developer run only 1 command to migrate from v4 to v5 (with JSS as a dependency so the application does not crash and they can continue fixing other breaking changes that codemod cannot fix)
jscodeshift
flag similar toreact-codemod
for "double-quote" optionsReview note
The implementation is quite hard to review so checking
*.test
folder that containsactual
andexpected
result might be better.Testing Result
I have tested this codemod version with community projects and material-ui-store.