Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TimePicker] Change default minutes and seconds to zero #27037

Merged
merged 9 commits into from Jul 9, 2021
Merged

[TimePicker] Change default minutes and seconds to zero #27037

merged 9 commits into from Jul 9, 2021

Conversation

michal-perlakowski
Copy link
Contributor

@michal-perlakowski michal-perlakowski commented Jun 30, 2021 •
edited

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 30, 2021 •
edited

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against a70f6a2

eps1lon
eps1lon reviewed Jun 30, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but really should have some tests.

@eps1lon eps1lon added bug 🐛 Something doesn't work component: time picker This is the name of the generic UI component, not the React module! PR: needs test The pull request can't be merged labels Jun 30, 2021
@github-actions github-actions bot mentioned this pull request Jun 30, 2021
Closed
mnajdova
mnajdova approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

eps1lon
eps1lon approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful test 😍
I added a confidence check so that it's obvious that we actually changed the hour.

@eps1lon eps1lon removed the PR: needs test The pull request can't be merged label Jul 1, 2021
@mnajdova mnajdova merged commit a76bb42 into mui:next Jul 9, 2021
@michal-perlakowski michal-perlakowski deleted the minute branch July 9, 2021 13:15
@eps1lon eps1lon mentioned this pull request Sep 14, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: time picker This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
4 participants
@michal-perlakowski @mui-pr-bot @mnajdova @eps1lon