[test] Enable skipped picker tests #27268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For context, I recall skipping a number of pickers test that were flaky, failing depending on the current date or time. It will be interesting to see how they behave once in HEAD. |
I think most of them were skipped before we've identified how dates and default timezones behave. Some tests were also just wrong. |
was fixed when we considered default timezones in safari
same pattern as e.g. PickersDay
This reverts commit 91c3ae7. Test and implementation are inaccurate
eps1lon
force-pushed
the
test/picker-enable-tests
branch
from
91c3ae7
to
4aa6e16
Compare
Same issue that isn't fixed yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either wrong testing patterns, or fixed in other PRs (e.g. default timezone in Safari), or better tested with visual regression.