New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add constant for the banner height #27309
Conversation
Details of bundle changes.Comparing: f3d2d7a...e4853b3 Details of page changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great. Note that the banner is still here in v3: https://v3.material-ui.com/ we might never remove it for v4 either 😁
That's why I didn't bother much at the start with adding constant etc, but yeah, it's anyway better now :) |
Creating
BANNER_HEIGHT
constant for easier replacing/removing the updates, once the banner is removed.