Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Remove unnecessary check for children.props.tabIndex #27374

Merged
merged 2 commits into from
Jul 27, 2021
Merged

[Modal] Remove unnecessary check for children.props.tabIndex #27374

merged 2 commits into from
Jul 27, 2021

Conversation

noviicee
Copy link
Contributor

fixes #27284

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 20, 2021 •
edited

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against f959dc7

@noviicee noviicee changed the title Issue 27284 Fixed unnecessary check for children.props.tabIndex Jul 20, 2021
@noviicee
Copy link
Contributor Author

@oliviertassinari kindly check this.

@oliviertassinari oliviertassinari changed the title Fixed unnecessary check for children.props.tabIndex [Modal] Remove unnecessary check for children.props.tabIndex Jul 20, 2021
@oliviertassinari oliviertassinari added the component: modal This is the name of the generic UI component, not the React module! label Jul 20, 2021
@oliviertassinari oliviertassinari merged commit 5e6d955 into mui:next Jul 27, 2021
@oliviertassinari
Copy link
Member

@noviicee Thanks, a tiny bundle size improvement

Capture d’écran 2021-07-27 à 13 22 41

@noviicee
Copy link
Contributor Author

@noviicee Thanks, a tiny bundle size improvement

Capture d’écran 2021-07-27 à 13 22 41

😂 I am trying to contribute more.

@noviicee noviicee deleted the issue-27284 branch July 27, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: modal This is the name of the generic UI component, not the React module! performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Modal] Probably unnecessary check for children.props.tabIndex
3 participants
@noviicee @mui-pr-bot @oliviertassinari