Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accordion] Fix AccordionSummary false-positive propType warning with disableGeneration #27385

Merged
merged 2 commits into from
Jul 22, 2021
Merged

[Accordion] Fix AccordionSummary false-positive propType warning with disableGeneration #27385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a51cc9
[AccordionSummary] Fix false-positive propType warning with `disableG…
eps1lon Jul 21, 2021
0669fe3
Update packages/material-ui/src/AccordionSummary/AccordionSummary.js
eps1lon Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/material-ui/src/AccordionSummary/AccordionSummary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,9 @@ AccordionSummary.propTypes = {
* See [CSS API](#css) below for more details.
*/
classes: chainPropTypes(PropTypes.object, (props) => {
if (props.classes.focused.indexOf(' ') !== -1) {
// Guard against when generation of classes is disabled in the stylesheets (`disableGeneration`).
// For `disableGeneration` we don't have an accurate warning but `disableGeneration` is an advanced use case anyway.
if (props.classes.focused !== undefined && props.classes.focused.indexOf(' ') !== -1) {
return new Error(
[
'Material-UI: The `classes.focused` key is deprecated.',
Expand Down