Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove mocks of require.context in markdown loader #27406

Merged
merged 7 commits into from Aug 10, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 22, 2021

Review with "hide whitespace changes" is recommended.

  1. remove requireRaw mock
  2. remove requireDemo mock (but make sure attempting to render a non-existent demo throws)
  3. skip transpiling code created by loader
    This was fairly expensive to do with large markdown files and we don't really need it. We can write es5 code directly instead.

Test plan

@eps1lon eps1lon added performance core Infrastructure work going on behind the scenes labels Jul 22, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 22, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 2ce0f18

@eps1lon eps1lon marked this pull request as ready for review July 23, 2021 07:46
@eps1lon eps1lon merged commit b664deb into mui:next Aug 10, 2021
@eps1lon eps1lon deleted the docs/require-keys branch August 10, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants