-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add customization demos #27411
Conversation
460b8fc
to
da613f4
Compare
🚀 Looks great! I love the subtle gradient on the card! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We are asking for PlusJakartaSans, but we don't load it.
- What's the long term plan around this theming section? It's it only here temporarily before moving it to the marking pages? Is the plan to add a section for theming like we have one for customization on all the pages?
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
will remove it in this PR, and add it in rebranding. |
…cs/card-customization
…ial-ui into docs/card-customization
I think it is nice to have a theming section in a component page apart from customization with |
@@ -105,6 +105,12 @@ This might be less confusing to users compared to a change in direction. | |||
|
|||
{{"demo": "pages/components/slider/VerticalAccessibleSlider.js"}} | |||
|
|||
## Theming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the section be right after ## Customized sliders
?
Also, if we move with ## Theming
for the other pages, I would propose we simplify the customization header (## Customized sliders
in this page) to ## Customization
on all the pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oliviertassinari is it better if we use the word "styling" rather than "customization"? I feel "customization" is broader than just css. @danilo-leal any thought?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could consider too:
## Customization
### Styling
### Theming
but maybe it's too deep and a flatten structure would help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I prefer flatten structure.
## Styling
## Theming
I think I will keep Customization
and ask the team about changing to Styling
so the change does not overload in this PR. @oliviertassinari should I merge the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Do you want Danilo to have a look at the new demos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that Theming
should live in isolation from Customization
. I believe they are about the same thing. You're customizing the components by applying a given theme in them. But, although this discussion is very important, I don't feel like this is the PR/place to discuss it already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danilo-leal then I will remove them from the theming section and merge until we have a conclusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good! I've made just small tweaks to them, especially regarding the cards in dark mode and the tabs contrast. You can check on the Figma file for quick scanning.
46b0452
to
29f1f7d
Compare
29f1f7d
to
7a3ec82
Compare
Summary
AddTheming
section to these pages. (to be used in rebranding).CardsTableDatePickerSliderChipTabsTimelineToggleButtonAdd themed components for rebranding. for demos, will find a conclusion about where to show.