-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Add references section to home #27444
Conversation
…branding/referencing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -46,7 +46,7 @@ const PRODUCTS = [ | |||
]; | |||
|
|||
export default function HeaderNavDropdown() { | |||
const [open, setOpen] = React.useState(true); | |||
const [open, setOpen] = React.useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mistake from the previous PR.
@@ -156,6 +156,7 @@ export default function HeaderNavBar() { | |||
anchorEl={productsMenuRef.current} | |||
transition | |||
placement="bottom-start" | |||
style={{ zIndex: 1200 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mistake from the previous PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be able to poll a value from theme.zIndex?
}} | ||
> | ||
<Grid item xs={4} md={2}> | ||
<img src="/static/branding/pricing/coursera.svg" alt="Coursera logo" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to reorganize these assets. We could for instance use /static/company/
for the assets related to the branding of our company.
<img src="/static/branding/pricing/coursera.svg" alt="Coursera logo" /> | ||
</Grid> | ||
<Grid item xs={4} md={2}> | ||
<img src="/static/branding/pricing/amazon.svg" alt="Amazon logo" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to set a size otherwise the layout is moving when they load. See https://github.com/mui-org/material-ui/blob/b33187aed8b542e9b33f4df2506e0e41a3b82bc2/docs/src/modules/branding/BrandingCustomerIcons.tsx#L6-L18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one.
We have a couple of HTML issues on the page https://validator.w3.org/nu/?doc=https%3A%2F%2Fdeploy-preview-27444--material-ui.netlify.app%2Fbranding%2Fhome%2F. For instance: |
Preview: https://deploy-preview-27444--material-ui.netlify.app/branding/home/
/static/icons/*
Webflow reference
https://rebranding-demo.webflow.io/