Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Restore overflowX and overflowY styles #27487

Merged
merged 8 commits into from
Aug 5, 2021
Merged

[Modal] Restore overflowX and overflowY styles #27487

merged 8 commits into from
Aug 5, 2021

Conversation

PCOffline
Copy link
Contributor

@PCOffline PCOffline commented Jul 28, 2021 •
edited by eps1lon

Closes #27486

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 28, 2021 •
edited

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against d1e16ec

@github-actions github-actions bot mentioned this pull request Jul 28, 2021
Closed
@PCOffline
Copy link
Contributor Author

Sorry for the commit names inconsistency by the way

@eps1lon eps1lon changed the title Fix: Select Overflow Restore [Modal] Restore overflowX and overflowY styles Jul 30, 2021
@eps1lon eps1lon added bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module! labels Jul 30, 2021
eps1lon
eps1lon requested changes Jul 30, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated 👍🏻

Just needs some small tweaks to the tests.

Confirmed that this works in a browser: https://codesandbox.io/s/modal-overflowx-restore-forked-v6jrb

Sorry for the commit names inconsistency by the way

No worries. We'll squash+merge anyway and use the PR title.

packages/material-ui-unstyled/src/ModalUnstyled/ModalManager.test.js Outdated Show resolved Hide resolved
packages/material-ui-unstyled/src/ModalUnstyled/ModalManager.test.js Outdated Show resolved Hide resolved
packages/material-ui-unstyled/src/ModalUnstyled/ModalManager.test.js Outdated Show resolved Hide resolved
@PCOffline
Copy link
Contributor Author

No idea why the test failed...

@PCOffline
Copy link
Contributor Author

@eps1lon may you help me out with this one? Any idea why the test took so long?

@PCOffline
Copy link
Contributor Author

Great, I had a feeling the tests simply needed a restart. May we merge now?

@eps1lon
Copy link
Member

eps1lon commented Aug 5, 2021

Great, I had a feeling the tests simply needed a restart. May we merge now?

Sure, just needed to make sure we don't merge unnecessary test changes.

@eps1lon eps1lon merged commit b5a5699 into mui:next Aug 5, 2021
@eps1lon
Copy link
Member

eps1lon commented Aug 5, 2021

@PCOffline It's a great first pull request on Material-UI. Thank you for working on it!

@PCOffline
Copy link
Contributor Author

Thank you for helping me out with it! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Modal] Overflow Styling In Body Removed After Select Component Is Closed
3 participants
@PCOffline @mui-pr-bot @eps1lon