Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codemod] Fix jss-to-styled PREFIX generation on Windows #27491

Merged
merged 3 commits into from
Jul 30, 2021
Merged

[codemod] Fix jss-to-styled PREFIX generation on Windows #27491

merged 3 commits into from
Jul 30, 2021

Conversation

mnajdova
Copy link
Member

When testing the codemod on the store (https://github.com/mui-org/material-ui-store/pull/55) the PREFIX was wrongly generated on Windows:

const PREFIX = 'D:\\workspace\\material-ui-store\\web\\src\\modules\\components\\FormButton';

This PR fixes it to be:

const PREFIX = 'FormButton'

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 28, 2021 •
edited

No bundle size changes (experimental)

Generated by 🚫 dangerJS against a172e18

@github-actions github-actions bot mentioned this pull request Jul 28, 2021
Closed
mnajdova and others added 2 commits July 29, 2021 14:07
@mnajdova @michaldudak
Update packages/material-ui-codemod/src/v5.0.0/jss-to-styled.js
48b38ee 
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
@mnajdova
nodePath
a172e18
@oliviertassinari oliviertassinari added package: codemod Specific to @mui/codemod bug 🐛 Something doesn't work labels Jul 29, 2021
michaldudak
michaldudak approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eps1lon eps1lon merged commit b9a5539 into mui:next Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work package: codemod Specific to @mui/codemod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mnajdova @mui-pr-bot @michaldudak @oliviertassinari @eps1lon