Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Fix nextjs with styled-components example #27583

Merged

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Aug 3, 2021

Fixes #27512

The PR implements #27088 (comment). It replaces the webpack alias with package alias. This also fixed the class name mismatch error.


I will update the other examples in a separate PR.

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 3, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 75f740e

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: styled-engine-sc Specific to styled-components labels Aug 3, 2021
@oliviertassinari
Copy link
Member

@mnajdova Did you have the opportunity to look at why we have this warning? I'm asking because we have the same issue with our documentation. It might be a reproduction simpler to investigate.

@mnajdova
Copy link
Member Author

mnajdova commented Aug 3, 2021

@mnajdova Did you have the opportunity to look at why we have this warning? I'm asking because we have the same issue with our documentation. It might be a reproduction simpler to investigate.

I haven't look too deep, I just tested that it is fixed by these changes, to be honest, I am not sure why. I will check later today tomorrow to see if the docs will still have the warning if we use package alias too (currently it depend on babel alias)

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@mnajdova mnajdova requested a review from eps1lon August 4, 2021 12:28
@mnajdova
Copy link
Member Author

mnajdova commented Aug 4, 2021

@mnajdova Did you have the opportunity to look at why we have this warning? I'm asking because we have the same issue with our documentation. It might be a reproduction simpler to investigate.

I tried to configure the docs to use package alias, but I didn't manage to. No matter what I use in the package.json in the end the babel alias wins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: styled-engine-sc Specific to styled-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js + Material UI v5 styled-component example is still showing className mismatch error
4 participants