[docs] Improve right to left guide #27713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
eps1lon
requested changes
Aug 13, 2021
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
|
|
||
| {{"demo": "pages/guides/right-to-left/RtlOptOut.js", "hideEditButton": true}} | ||
| {{"demo": "pages/guides/right-to-left/RtlOptOutStylis.js", "hideToolbar": true}} |
There was a problem hiding this comment.
One detail, if we only want to disable the preview and keep the toolbar, we could use "defaultCodeOpen": false.
There was a problem hiding this comment.
Most of this demo is irrelevant. It really is just about noflip usage.
eps1lon
approved these changes
Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27701
Changes done:
emotionandstyled-componentsfirststylisin the instruction for the installation of thestylis-plugin-rtl(I've spent an hour debugging [docs] RTL not working when stylis is not installed #27701 before I realized thatstylisis missing in the dependencies)Preview https://deploy-preview-27713--material-ui.netlify.app/guides/right-to-left/