Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update .browserslistrc file #27788

Merged
merged 9 commits into from Aug 18, 2021

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Aug 16, 2021

Breaking changes


Update our .browserslistrc one final time before stable release following the comments in the file.

@DanailH DanailH added the core Infrastructure work going on behind the scenes label Aug 16, 2021
@DanailH DanailH requested a review from eps1lon August 16, 2021 10:42
@DanailH DanailH self-assigned this Aug 16, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 16, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 252eb21

.browserslistrc Outdated Show resolved Hide resolved
.browserslistrc Outdated Show resolved Hide resolved
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/src/pages/guides/migration-v4/migration-v4.md Outdated Show resolved Hide resolved
test/karma.conf.js Outdated Show resolved Hide resolved
.browserslistrc Outdated Show resolved Hide resolved
docs/src/pages/guides/migration-v4/migration-v4.md Outdated Show resolved Hide resolved
@eps1lon eps1lon added this to the v5 milestone Aug 17, 2021
@@ -11,7 +11,7 @@ You don't need to provide any JavaScript polyfill as it manages unsupported brow

| Edge | Firefox | Chrome | Safari (macOS) | Safari (iOS) | IE |
| :---- | :------ | :----- | :------------- | :----------- | :------------------- |
| >= 85 | >= 78 | >= 84 | >= 13 | >= 12.1 | 11 (partial support) |
| >= 91 | >= 78 | >= 90 | >= 14 | >= 12.5 | 11 (partial support) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browserslist does not have support yet for 12.5 which was released 8 months ago

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Published syntax did not change (considering no bundle size changes).

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice, if we could update the issue's description to describe the breaking change, so we can create the changelog more easily during the release, it would be perfect.

@DanailH I think that we should replicate this change in MUI X too.

@@ -166,7 +166,7 @@ module.exports = function setKarmaConfig(config) {
os: 'OS X',
os_version: 'Catalina',
browser: 'chrome',
browser_version: '84.0',
browser_version: '90.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering all the test failures we may want to hold off on changing this until we figured out what changed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so we should revert back to 84.0 right.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently bisecting what's possible. Will push a fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a browserstack problem. For some reason programmatic focus no longer causes focus in Chrome >=89 using browserstack. It's working perfectly fine not using browserstack.

@DanailH
Copy link
Member Author

DanailH commented Aug 18, 2021

Should we merge this?

@eps1lon eps1lon merged commit 65cee17 into mui:next Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants