New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Update .browserslistrc
file
#27788
[core] Update .browserslistrc
file
#27788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to update https://deploy-preview-27788--material-ui.netlify.app/getting-started/supported-platforms/ too?
@@ -11,7 +11,7 @@ You don't need to provide any JavaScript polyfill as it manages unsupported brow | |||
|
|||
| Edge | Firefox | Chrome | Safari (macOS) | Safari (iOS) | IE | | |||
| :---- | :------ | :----- | :------------- | :----------- | :------------------- | | |||
| >= 85 | >= 78 | >= 84 | >= 13 | >= 12.1 | 11 (partial support) | | |||
| >= 91 | >= 78 | >= 90 | >= 14 | >= 12.5 | 11 (partial support) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
browserslist
does not have support yet for 12.5 which was released 8 months ago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Published syntax did not change (considering no bundle size changes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiice, if we could update the issue's description to describe the breaking change, so we can create the changelog more easily during the release, it would be perfect.
@DanailH I think that we should replicate this change in MUI X too.
test/karma.conf.js
Outdated
@@ -166,7 +166,7 @@ module.exports = function setKarmaConfig(config) { | |||
os: 'OS X', | |||
os_version: 'Catalina', | |||
browser: 'chrome', | |||
browser_version: '84.0', | |||
browser_version: '90.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering all the test failures we may want to hold off on changing this until we figured out what changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so we should revert back to 84.0
right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently bisecting what's possible. Will push a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a browserstack problem. For some reason programmatic focus no longer causes focus in Chrome >=89 using browserstack. It's working perfectly fine not using browserstack.
Should we merge this? |
Breaking changes
Update our
.browserslistrc
one final time before stable release following the comments in the file.