[Autocomplete] Add verbose warning for defaultValue #27925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedadeepta
force-pushed
the
24785-autocomplete-defaultValue-warning
branch
from
9898167
to
a0427f2
Compare
eps1lon
reviewed
Aug 23, 2021
| 'Autocomplete', | ||
| ); | ||
| }).toErrorDev( | ||
| 'The Autocomplete expects the `defaultValue` prop to be an array or undefined.', |
There was a problem hiding this comment.
Suggested change
| 'The Autocomplete expects the `defaultValue` prop to be an array or undefined.', | |
| 'The Autocomplete expects the `defaultValue` prop to be an array when `multiple={true}` or undefined.', |
There was a problem hiding this comment.
OK, should I change the warning for value prop too, because the condition under which we show the warning are same for both defaultValue & value.
There was a problem hiding this comment.
OK, should I change the warning for value prop too
@vedadeepta Yes please. It's the same warning, respectively for the controlled and uncontrolled behavior of the "value" state.
There was a problem hiding this comment.
too late now, should I open a different PR or re-open this one?
There was a problem hiding this comment.
A follow-up PR sounds great
oliviertassinari
changed the title
1 task
zannager
added
the
component: autocomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24785