Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Use deeper imports from unstyled, correct docs #28074

Merged
merged 5 commits into from Sep 8, 2021
Merged

[Button] Use deeper imports from unstyled, correct docs #28074

merged 5 commits into from Sep 8, 2021

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Aug 31, 2021 •
edited by oliviertassinari

@michaldudak michaldudak changed the title [Button] Change import paths, correct docs [Button] Use deeper imports from unstyled, correct docs Aug 31, 2021
@michaldudak michaldudak mentioned this pull request Aug 31, 2021
Merged
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 31, 2021 •
edited

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 4995764

@mnajdova
Copy link
Member

Could we wait for the package rename changes to go in before we merge this one?

@michaldudak
Copy link
Member Author

Sure, no problem

@github-actions github-actions bot mentioned this pull request Aug 31, 2021
Closed
@oliviertassinari oliviertassinari added component: button This is the name of the generic UI component, not the React module! new feature New feature or request labels Aug 31, 2021
oliviertassinari
oliviertassinari reviewed Aug 31, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, a small detail PR 🍭, but the CI is failing 😁

@oliviertassinari
Copy link
Member

I think that it fails because of https://github.com/mui-org/material-ui/blob/bbc5561f360985430fc6ef4f81eca0ce093eaf98/packages/material-ui/scripts/rollup.config.js#L85 while we have a .ts file not a .js one.

@michaldudak
Copy link
Member Author

@oliviertassinari Is there some known workaround or should I try to fix the config?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 1, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 1, 2021 •
edited

I guess we need to fix this line. We could test if the ts file is present, return it and default to the .js file if not.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 1, 2021
@michaldudak michaldudak mentioned this pull request Sep 1, 2021
Merged
@michaldudak
Copy link
Member Author

Fixing in #28094

oliviertassinari
oliviertassinari reviewed Sep 2, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the follow up.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 6, 2021
@michaldudak
Copy link
Member Author

Looks great, thanks for the follow up.

@oliviertassinari can I have approval, then? 😉

mnajdova
mnajdova approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the approval :))

@michaldudak
Copy link
Member Author

Thanks :)

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 7, 2021
@michaldudak michaldudak merged commit dc3f537 into mui:next Sep 8, 2021
@michaldudak michaldudak deleted the button-docs-fixes branch September 8, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: button This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michaldudak @mui-pr-bot @mnajdova @oliviertassinari