Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve diamond sponsors in the navigation #28090

Merged
merged 2 commits into from Sep 2, 2021
Merged

[docs] Improve diamond sponsors in the navigation #28090

merged 2 commits into from Sep 2, 2021

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Sep 1, 2021 •
edited by oliviertassinari

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 1, 2021 •
edited

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 9af0a53

@github-actions github-actions bot mentioned this pull request Sep 1, 2021
Closed
oliviertassinari
oliviertassinari reviewed Sep 1, 2021
View reviewed changes
docs/src/modules/components/DiamondSponsors.js Outdated
@@ -74,9 +74,9 @@ export default function DiamondSponsors(props) {
}}
>
<img
width="42"
width="150"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image sources are 250x70. It's not compatible with a rendering zone of 150x42. You can find the originals in Figma and export it to 300x84. I noticed because it looked crispy on my phone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find the logo with the text. I will wait for @danilo-leal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed a commit with the Octopus full logo in svg. I think it resolves the crispness of the png!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danilo-leal 🙏

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 1, 2021
danilo-leal
danilo-leal approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, both logos are svg now!

Light Dark
Screen Shot 2021-09-01 at 11 34 43 Screen Shot 2021-09-01 at 11 34 50

*PS: I had pointed this out on the Markdown polish PR, but I couldn't find a svg DoiT logo with the "international" word below. Not sure if it's a big problem. If it is, we could probably ask them for a svg, I figure they would be happy to share!

@mnajdova mnajdova merged commit 26abce8 into mui:next Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mbrookes mbrookes mbrookes approved these changes

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mnajdova @mui-pr-bot @mbrookes @oliviertassinari @danilo-leal