Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix broken/incorrect attributes links in Avatar and NativeSelect API pages #28417

Merged
merged 3 commits into from Sep 18, 2021

Conversation

xenostar
Copy link
Contributor

@xenostar xenostar commented Sep 17, 2021

I noticed some broken attributes links in the API docs for Avatar and NativeSelect. It also seems like the attributes links were pointing to the completely incorrect page in addition to being broken. Avatar was pointing to Input element attributes on MDN, and NativeSelect was pointing to the same as well. I change them to point to image and select attributes respectively.

This is my first PR here so let me know if I did anything wrong.

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 17, 2021

No bundle size changes

Generated by 🚫 dangerJS against 87d6187

@xenostar xenostar changed the title [docs] Fix broken attributes links in Avatar and NativeSelect API pages [docs] Fix broken/incorrect attributes links in Avatar and NativeSelect API pages Sep 17, 2021
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@eps1lon eps1lon merged commit f924926 into mui:master Sep 18, 2021
@eps1lon
Copy link
Member

eps1lon commented Sep 18, 2021

@xenostar It's a great first pull request on Material-UI. Thank you for working on it!

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 18, 2021
@xenostar
Copy link
Contributor Author

Thanks @eps1lon. Glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants