[website] Fix crash #28474
Merged
[website] Fix crash #28474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
requested changes
Sep 19, 2021
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
siriwatknp
reviewed
Sep 20, 2021
| if (parts.length === 2) { | ||
| return parts[1].split(';').shift(); | ||
| } | ||
| if (typeof document === 'undefined') { |
There was a problem hiding this comment.
Adding a test would be nice.
There was a problem hiding this comment.
What would the test be about?
There was a problem hiding this comment.
getCookie function that it returns the correct result. No strong opinion, it is just easier to me if there is a test I can see for input & output.
There was a problem hiding this comment.
Oh, I see. I'm not aware of a precedent to test cookies, it could be interesting. I'm in the same boat, I don't really know how this function works.
eps1lon
approved these changes
Sep 20, 2021
siriwatknp
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, I wanted to fix https://twitter.com/sairaj2119/status/1439453551944552448. Open https://mui.com/core/ and click on "Table", it crashes
but then I also noticed:
Fixes #28487