[test] Increase BS timeout for Firefox #28476
Conversation
There was a problem hiding this comment.
This PR aims to evaluate how much faster the latest version of Firefox is in BrowserStack.
That's irrelevant. By this point running Firefox tests is just useless. Either we drop them completely, run on the lowest or look for browser tests that don't break. But this constant "we really need them, I just don't have any arguments anymore" is tireing.
|
It took 3 minutes to run test tests, which is the same as when the Firefox runs behave normally. Bumping the version doesn't seem to help fix the flakiness issue. I suspect the issue is more with an infra issue on the BrowserStack side, with a high variance (maybe they have different pools per version, no idea). I'm updating the timeout to 10minutes. Now that we run these tests a lot less frequently, it's probably OK. Once we hit a capacity issue, we could reconsider: bump to the latest version of Firefox, drop Firefox, move Firefox run to CircleCI, etc. |
oliviertassinari
changed the title
oliviertassinari
dismissed
eps1lon’s stale review
I have updated the approach
The tests with Firefox 78 are frequently hitting the timeout. It's much slower than the other browsers.
This PR aims to evaluate how much faster the latest version of Firefox is in BrowserStack.didn't work