Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add components index page #28485

Merged
merged 7 commits into from Sep 21, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Sep 20, 2021

Preview: https://deploy-preview-28485--material-ui.netlify.app/components/

This page is essential for setting page_rank of all components to appear first in docsearch. According to #28333

Screen Shot 2564-09-20 at 14 31 43

  • For the design, I make it similar to Navigation drawer but with our Masonry component! (I think we can go with this simple design at first to unblock the docsearch improvement because it can only be access directly from the url and later improve with fancy design)
  • Same pages data as in navigation

@siriwatknp siriwatknp added the website Pages that are not documentation-related, marketing-focused. label Sep 20, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 20, 2021

No bundle size changes

Generated by 🚫 dangerJS against 213580f

@siriwatknp siriwatknp mentioned this pull request Sep 20, 2021
4 tasks
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we render something simpler? This page isn't that important right now to look perfect. But looking broken is worse:

  1. double scrollbar
  2. overlapping items
    Screenshot from 2021-09-20 11-08-31

@siriwatknp
Copy link
Member Author

looking broken is worse

Oh no, it was working in my machine. I will remove Masonry and use simple grid instead.

@eps1lon
Copy link
Member

eps1lon commented Sep 20, 2021

looking broken is worse

Oh no, it was working in my machine. I will remove Masonry and use simple grid instead.

Would be nice to track this in a separate issue for the Masonry with a codesandbox.

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now! Excited to revamp this one later on :)

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link self-reference itself.

Screenshot 2021-09-21 at 00 12 03

docs/pages/components.tsx Outdated Show resolved Hide resolved
@oliviertassinari
Copy link
Member

Oh no, it was working in my machine. I will remove Masonry and use simple grid instead.

cc @hbjORbj

siriwatknp and others added 2 commits September 21, 2021 09:37
Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@siriwatknp
Copy link
Member Author

This link self-reference itself.

Good catch, there are children in the menus. Fixed!

Screen Shot 2564-09-21 at 10 02 25

@siriwatknp siriwatknp merged commit f8fcae6 into mui:master Sep 21, 2021
@hbjORbj
Copy link
Member

hbjORbj commented Sep 27, 2021

Can we render something simpler? This page isn't that important right now to look perfect. But looking broken is worse:

  1. double scrollbar
  2. overlapping items
    Screenshot from 2021-09-20 11-08-31

I think this comes from the known limitation of current masonry implementation (issue: #27934)
As a result of this limitation, a scrollbar appears in masonry, and items at the bottom start to get squashed if masonry's height goes beyond 2,000px. This is obviously a very serious limitation, and it's the main reason to go for the flexbox approach (PR: #28059)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants