[docs] Avoid re-mounting the whole tree when switching theme direction #28495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Sep 20, 2021
|
|
||
| return ( | ||
| <StyleSheetManager stylisPlugins={rtl ? [rtlPluginSc] : []}> | ||
| <Wrapper {...wraperProps}>{props.children}</Wrapper> |
There was a problem hiding this comment.
Changing Wrapper meant that all children will get re-mounted. Especially high up in React trees, changing parent element types should be avoided at all cost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching between right-to-left and left-to-right currently re-mounts the whole tree since we inject an additional CacheProvider for right-to-left. It's unclear why. Instead, we use a single CacheProvider and just pass a different value.
This also helps identifying where a cache is coming from.