Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add custom queries to screen #28507

Merged
merged 1 commit into from Sep 21, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 21, 2021

Adds screen.queryDescriptionOf, screen.getDescriptionof, and screen.findDescriptionOf.

Also re-enable ByLabelText. It's widely used in the pickers test. Ideally we'd never use it because it requires deep understanding of its limitations. But it has a perf benefit which is especially notable in pickers test. Just have to bet on developer discipline that it's not abused.

@eps1lon eps1lon added the test label Sep 21, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 21, 2021

No bundle size changes

Generated by 🚫 dangerJS against 3e2176f

@eps1lon eps1lon merged commit afd98f9 into mui:master Sep 21, 2021
@eps1lon eps1lon deleted the test/screen-custom-queries branch September 21, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants