Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system] Fix types to support theme callbacks on pseudo and nested selectors #28570

Merged
merged 3 commits into from
Sep 27, 2021
Merged

[system] Fix types to support theme callbacks on pseudo and nested selectors #28570

merged 3 commits into from
Sep 27, 2021

Conversation

mnajdova
Copy link
Member

Fixes #28523

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 24, 2021 •
edited

No bundle size changes

Generated by 🚫 dangerJS against 06ea941

@oliviertassinari oliviertassinari added package: system Specific to @mui/system typescript labels Sep 24, 2021
eps1lon
eps1lon approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear tests 👍🏻

@mnajdova mnajdova merged commit 2dd7d29 into mui:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
package: system Specific to @mui/system typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript error when using a theme callback in SX prop for a class
4 participants
@mnajdova @mui-pr-bot @eps1lon @oliviertassinari