Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Mention Premium pricing cap #28581

Merged
merged 7 commits into from
Sep 24, 2021
Merged

[docs] Mention Premium pricing cap #28581

merged 7 commits into from
Sep 24, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 24, 2021 •
edited

This PR batches a few small changes:

  • Add the missing pricing cap "Price capped at 10 developers per application"
  • Fix anchor naming convention: kebab case, as the other parts of the URL: EarlyBird -> early-bird
  • Remove unnecessary div
  • Increase the contrast between palette.text.primary and palette.text.secondary. I'm not so sure about this one. I was personally struggling to see a difference in the text between the two
  • Make the Ad "powered by" mention less visible
  • Update a few headers to match the convention
  • Add a new FAQ for the design kits, related to https://github.com/mui-org/mui-store/pull/70

Preview: https://deploy-preview-28581--material-ui.netlify.app/

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation website Pages that are not documentation-related, marketing-focused. labels Sep 24, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 24, 2021 •
edited

No bundle size changes

Generated by 🚫 dangerJS against aebc4ed

danilo-leal
danilo-leal approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Agree about the contrast between primary and secondary on the text though. I'll give it a look outside of this PR and then we come back to it later.

@oliviertassinari oliviertassinari merged commit 4773fff into mui:master Sep 24, 2021
@oliviertassinari oliviertassinari deleted the batch-small-fixes-v6 branch September 24, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviertassinari @mui-pr-bot @danilo-leal