Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove languages: fr, de, ja, es, ru #28663

Merged
merged 6 commits into from
Sep 29, 2021

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Sep 28, 2021

The PR removes the following languages from the docs - fr, de, ja, es, ru. The community has not been able to translate them enough. They are up to date, but in English, so not really helpful. They are also the ones with the less usage.

I recommend review per commit.

I've also added redirects for the languages that are removed, let me know if I should revert this change.

TODO:

@mnajdova
Copy link
Member Author

@mbrookes what should be changed on https://translate.mui.com?

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 28, 2021

No bundle size changes

Generated by 🚫 dangerJS against d894452

@mnajdova mnajdova marked this pull request as ready for review September 28, 2021 10:59
@eps1lon
Copy link
Member

eps1lon commented Sep 28, 2021

We should flip https://github.com/mui-org/material-ui/blob/5c68fe51b3369a746e82c1594046bc69f3821dd9/docs/next.config.js#L211-L211 to build all locales for testing purposes before merging.

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 28, 2021

I think that we should update https://github.com/mui-org/material-ui-com/blob/master/_redirects to redirect the old URLs. For instance https://material-ui.com/fr/components/alert/ should be a 301 to https://mui.com/components/alert/.

@@ -177,6 +177,8 @@ https://v4.material-ui.com/* https://v4.mui.com/:splat 301!
/fr/* /:splat 200
/de/* /:splat 200
/ja/* /:splat 200
/ru/* /:splat 200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added redirects for the languages that are removed

These are not redirections, they are proxies.

Copy link
Member Author

@mnajdova mnajdova Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I haven't noticed the HTTP status code. Were these previously added for the new pages only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we actually make these redirects if we no longer want to support these languages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fr, de, ja were not server-side rendered (next.js exportPathMap function), so we had to proxied them. In our case, we can turn them all to a 301. No need for the ! as the HTML files won't exist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaah ok, it makes sense now, wasn't sure why these three were only added. Thanks for the clarification. Will update them now

@mnajdova
Copy link
Member Author

@mbrookes
Copy link
Member

what should be changed on https://translate.mui.com

I'll remove the languages that have been removed here.

Frankly though, unless Crowdin step up, and fix the issues that prevent further translation of Chinese and Portuguese Brazilian, we might as well give up on translation altogether. It would be a terrible waste, given the time, effort and money that's gone into building the i18n infrastructure, and translations, but half translated is worse than untranslated.

@mnajdova mnajdova merged commit 9ab5f80 into mui:master Sep 29, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 29, 2021

It looks good. The next SEO crawl will ultimately confirm if it's a step forward 😁. I recall spending 4 weekends in a row in 2019 to fix everything. At each iteration, I would miss something.

@oliviertassinari
Copy link
Member

unless Crowdin step up

@mbrookes Would it make sense to give them an ultimatum?

I'm curious to see how React will handle this problem with https://github.com/reactjs/reactjs.org-translation. Did they say that they are working on a rewrite of the docs?

@mbrookes
Copy link
Member

mbrookes commented Oct 1, 2021

Would it make sense to give them an ultimatum?

A little hard to do when we use their services for free (even though we acknowledge them in the README). I've sent another follow-up to the case I opened in January. After that, I guess we look for an alternative, or give up on handling the docs i18n natively, and leave l10n to 3rd-party forks.

(Yes, React are doing a functional component/hooks based rewrite.)

I'll remove the languages that have been removed here.

This is done BTW, along with removing v4 master, and renaming next to master.

I took a local copy of the translations, in case we decide to reinstate any of them in the future.

@zannager zannager added the docs Improvements or additions to the documentation label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants