Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pricing] Add tooltip to pricing icon #28959

Merged
merged 2 commits into from
Oct 18, 2021
Merged

[pricing] Add tooltip to pricing icon #28959

merged 2 commits into from
Oct 18, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Oct 10, 2021 •
edited

This is reported through Zendesk "What is the meaning of the icons?".

Screen Shot 2564-10-10 at 12 55 09

This PR add tooltip title to the icons.

  • check = "Available"
  • clock = "Work in progress"
  • dash = "Not included"

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 10, 2021 •
edited

No bundle size changes

Generated by 🚫 dangerJS against 78f2e78

@siriwatknp siriwatknp marked this pull request as ready for review October 11, 2021 03:54
@michaldudak
Copy link
Member

Could we have Included/Not included or Available/Not available for consistency? (I personally prefer the first option).

@siriwatknp
Copy link
Member Author

Could we have Included/Not included or Available/Not available for consistency? (I personally prefer the first option).

What do you think? @danilo-leal

danilo-leal
danilo-leal approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, merging this one!

@danilo-leal danilo-leal merged commit dd6254e into mui:master Oct 18, 2021
@zannager zannager added component: tooltip This is the name of the generic UI component, not the React module! package: icons Specific to @mui/icons labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees
No one assigned
Labels
component: tooltip This is the name of the generic UI component, not the React module! package: icons Specific to @mui/icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@siriwatknp @mui-pr-bot @michaldudak @danilo-leal @zannager