Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Reduce min-height & padding in menu-item with dense property #29180

Merged
merged 4 commits into from Oct 22, 2021
Merged

[Menu] Reduce min-height & padding in menu-item with dense property #29180

merged 4 commits into from Oct 22, 2021

Conversation

jatinsandilya
Copy link
Contributor

@jatinsandilya jatinsandilya commented Oct 20, 2021 •
edited

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 20, 2021 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 157edc1

@jatinsandilya jatinsandilya changed the title [Menu] Reduce min-height & padding in menu-item with dense property [MenuItem] Reduce min-height & padding in menu-item with dense property Oct 20, 2021
@jatinsandilya jatinsandilya changed the title [MenuItem] Reduce min-height & padding in menu-item with dense property [Menu] Reduce min-height & padding in menu-item with dense property Oct 20, 2021
@danilo-leal danilo-leal added component: menu This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Oct 20, 2021
danilo-leal
danilo-leal approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least visually, this seems fine! Thanks for working on it :)

siriwatknp
siriwatknp approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your first contribution!

@jatinsandilya
Copy link
Contributor Author

Thanks @siriwatknp @danilo-leal for the quick review 👍🏼
When do you see this getting merged/released? Asking because I'd like to use this fix soon in our codebase. Sorry if this process is already documented somewhere I could not find it.

@siriwatknp
Copy link
Member

siriwatknp commented Oct 22, 2021 •
edited

Thanks @siriwatknp @danilo-leal for the quick review 👍🏼 When do you see this getting merged/released? Asking because I'd like to use this fix soon in our codebase. Sorry if this process is already documented somewhere I could not find it.

I think it can be merged today after I added the visual regression test.

@siriwatknp siriwatknp merged commit ffe07b9 into mui:master Oct 22, 2021
@jatinsandilya jatinsandilya deleted the menu-dense-padding branch October 22, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu component: Dense prop doesn't change padding
4 participants
@jatinsandilya @mui-pr-bot @siriwatknp @danilo-leal