Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add deploy context variables #29195

Merged
merged 5 commits into from Oct 22, 2021
Merged

[docs] Add deploy context variables #29195

merged 5 commits into from Oct 22, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Oct 21, 2021 •
edited

add deploy context variables for dynamic configuration between production and deploy-preview.

use cases

  • Email Subscribe URL
  • Joy docs can be tested in deploy-preview without releasing to production
  • Feature toggles

@siriwatknp siriwatknp marked this pull request as draft October 21, 2021 05:36
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 21, 2021 •
edited

No bundle size changes

Generated by 🚫 dangerJS against 70aaa25

siriwatknp
siriwatknp commented Oct 21, 2021
View reviewed changes
docs/src/config.ts Outdated Show resolved Hide resolved
siriwatknp
siriwatknp commented Oct 21, 2021
View reviewed changes
netlify.toml Outdated Show resolved Hide resolved
siriwatknp
siriwatknp commented Oct 21, 2021
View reviewed changes
docs/pages/_app.js Outdated Show resolved Hide resolved
@siriwatknp siriwatknp marked this pull request as ready for review October 21, 2021 08:42
hbjORbj
hbjORbj approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clear to me :)

@siriwatknp siriwatknp merged commit 72dbd85 into mui:master Oct 22, 2021
@zannager zannager added the docs Improvements or additions to the documentation label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@siriwatknp @mui-pr-bot @hbjORbj @zannager