[IconButton] Remove on hover effect when disableRipple is set
#29298
Conversation
|
Made your requested updates @mnajdova |
|
I made a couple more changes, can you take a look when you get the chance? @mnajdova |
|
Hey @mnajdova is this good to go? |
mbrookes
added
the
component: icon button
|
Hey @mnajdova bumping this one more time in an attempt to make my Hacktoberfest goal before the deadline. Hoping you can give it another look :) |
So sorry was a bit busy, the notification must have slipped. All good from my end. |
mnajdova
changed the title
disableRipple is set
|
the version of 5.8.6 can works now? |
| </IconButton>, | ||
| ); | ||
| expect(container.querySelector('.touch-ripple')).to.equal(null); | ||
| expect(getComputedStyle(getByRole('button'), ':hover').backgroundColor).to.equal( |
There was a problem hiding this comment.
This :hover argument is not valid for the getComputedStyle(element, pseudoElt) API. The second parameter expects a pseudo-element, not a pseudo-class, see https://stackoverflow.com/questions/11495535/why-doesnt-getcomputedstyle-work-with-pseudo-classes-like-hover.
It seems that we can't test this. I'm removing the test in: #34764 as it's always true.
Added a check for the
disableRippleprop before adding the on-hover background color styling.Addresses #11108