NOT FOR MERGE [test] Check runtime performance of testing-library/dom-testing-library#1068 #29368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing testing-library/dom-testing-library#1068
Results analyzed with https://www.calculatorsoup.com/calculators/statistics/mean-median-mode.php
test:unit
master
Sampled runs
Results
test:unitruntime:Mean x¯¯¯ 421.82
Median x˜ 454.99
Mode 454.99, 459.60, 489.28, 358.27, 346.96
Range 142.32
Minimum 346.96
Maximum 489.28
Count n 5
Sum 2109.1
Quartiles Quartiles:
Q1 --> 352.615
Q2 --> 454.99
Q3 --> 474.44
Interquartile
Range IQR 121.825
Outliers none
PR
Sampled runs
Results
Mean x¯¯¯ 321.75
Median x˜ 311.5
Mode 308.45, 314.55, 276.73, 387.27
Range 110.54
Minimum 276.73
Maximum 387.27
Count n 4
Sum 1287
Quartiles Quartiles:
Q1 --> 292.59
Q2 --> 311.5
Q3 --> 350.91
Interquartile
Range IQR 58.32
Outliers none
test:karma
master
Sampled runs
Results
Mean x¯¯¯ 62.2
Median x˜ 60
Mode 89, 49, 60, 61, 52
Range 40
Minimum 49
Maximum 89
Count n 5
Sum 311
Quartiles Quartiles:
Q1 --> 50.5
Q2 --> 60
Q3 --> 75
Interquartile
Range IQR 24.5
Outliers none
PR
Sampled runs
Results
Mean x¯¯¯ 65.25
Median x˜ 62
Mode 61, 53, 84, 63
Range 31
Minimum 53
Maximum 84
Count n 4
Sum 261
Quartiles Quartiles:
Q1 --> 57
Q2 --> 62
Q3 --> 73.5
Interquartile
Range IQR 16.5
Outliers none
Conclusion
While it's hard to tell if this change does in fact speed things up (ressource classes are flaky; wide spread to begin with) it seems safe to say that this didn't result in a significant slowdown.
Looks safe to land.