[DatePicker][TimePicker] Add missing component declarations #29517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
added
component: date picker
mbrookes
changed the title
michaldudak
requested changes
Nov 17, 2021
Done. |
michaldudak
approved these changes
Nov 18, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@mui/lab/themeAugmentationdeclarations were missing theMuiDatePickerandMuiDateTimePickercomponents. This made it not possible to override the props and styles for those components in a custom theme.It appears these components were at one point part of the declarations file https://github.com/mui-org/material-ui/pull/24092/files but not sure how it was dropped or lost.