[docs] Fix broken Next and Previous links #29711
Conversation
|
The build failure looks unrelated to my changes 🤔 |
oliviertassinari
added
bug 🐛
|
@scallaway The |
|
I guess this is the reason why some of the links in prod were working but others weren't? I did have a feeling it had something to locale or the like, since the lookup within the page title functionality wasn't working properly. It didn't really help that the errors thrown by React weren't that useful, so that could be something to be improved upon in the future? Maybe that's also just my unfamiliarity with the codebase, but surely you'd want that to be as welcoming to new devs as possible! Your changes do look a lot more robust than mine! |
| return { ...page, linkProps: { as: `${page.pathname.replace(/^\/api-docs/, '/api')}/` } }; | ||
| return { | ||
| ...page, | ||
| linkProps: { linkAs: `${page.pathname.replace(/^\/api-docs/, '/api')}/` }, |
There was a problem hiding this comment.
@mui-org/x heads up, this is a breaking change, you need to apply the same diff once you upgrade the mono-repo. We improve the support for the translation of the docs.
I still don't quite understand why this was caused, since the changes have been in master for a few days and I've been able to access the MUI docs in the interim (I think, although can't be fully sure since we haven't migrated from 4 to 5 yet), but I guess it's due to the way that you guys do releases?
I also have a feeling that the typing for the props expected to be passed to the
Linkcomponent indocs/src/modules/components/Link.tsxare slightly wrong since we should beOmiting thelinkAsprop as specified in the typing.Happy to have more of a look at this in the future, but this at least un-blocks the prod website from being completely broken.
Fixes #29704
Fixes #29708
https://deploy-preview-29711--material-ui.netlify.app/api/form-control-label/