Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Masonry] Export in packages/mui-lab/src/index.(js|d.ts) #29754

Merged
merged 1 commit into from
Nov 19, 2021
Merged

[Masonry] Export in packages/mui-lab/src/index.(js|d.ts) #29754

merged 1 commit into from
Nov 19, 2021

Conversation

abhinav-22-tech
Copy link
Contributor

@abhinav-22-tech abhinav-22-tech commented Nov 18, 2021

Fixes #29705 with the solution proposed by @siriwatknp

Source of error:

When attempting to use Masonry like so:
import {Masonry} from '@mui/lab';

the component cannot be found.

image

Fix:

By export Masonry in packages/mui-lab/src/index.(js|d.ts)

image

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 18, 2021

Details of bundle changes

@material-ui/lab: parsed: +1.03% , gzip: +1.22%

Generated by 🚫 dangerJS against dbba266

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your first contribution!

cc @hbjORbj for final check.

Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriwatknp siriwatknp merged commit 24ff946 into mui:master Nov 19, 2021
@mbrookes mbrookes changed the title Masonry export in packages/mui-lab/src/index.(js|d.ts) [Masonry] Export in packages/mui-lab/src/index.(js|d.ts) Nov 28, 2021
@mbrookes mbrookes added the component: masonry This is the name of the generic UI component, not the React module! label Nov 28, 2021
@abhinav-22-tech abhinav-22-tech deleted the masonry-export-in-index branch December 17, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: masonry This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Masonry] Masonry not exposed in top-level import
5 participants