Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove redundant grouping in /components/radio-buttons/ #30065

Merged
merged 1 commit into from Jan 17, 2022

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Dec 5, 2021

Successfull screen reader review: https://deploy-preview-30065--material-ui.netlify.app/components/radio-buttons/

Previously the demos created the following a11y tree group[name="Gender"] > group[name="Gender"] > radio-button[name="female"] resulting in a redundant announcement in screen-readers. RadioGroup already handles the grouping so we don't need another fieldset.

@eps1lon eps1lon added docs Improvements or additions to the documentation accessibility a11y component: radio This is the name of the generic UI component, not the React module! labels Dec 5, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 5, 2021

No bundle size changes

Generated by 🚫 dangerJS against dcf7dc6

@eps1lon eps1lon marked this pull request as ready for review December 9, 2021 21:10
@eps1lon eps1lon requested a review from a team January 16, 2022 11:00
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great! always learn new things from your PRs.

@michaldudak michaldudak merged commit b9b2321 into mui:master Jan 17, 2022
@eps1lon eps1lon deleted the docs/RadioGroup/redundant-grouping branch January 17, 2022 11:12
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y component: radio This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants