-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SliderUnstyled] Add useSlider hook and polish #30094
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
6814667
[SliderUnstyled] Update components & componentsProps
mnajdova 96c3dff
[useSlider] Add hook (WIP)
mnajdova f47b01c
proptypes & docs:api
mnajdova 086aa86
Improve logic for forwarding props
mnajdova 6f925a1
Various fixes
mnajdova d3c0033
prettier
mnajdova 26287cc
Update test/utils/describeConformanceUnstyled.tsx
mnajdova bd62bb2
Run prettier
hbjORbj 57ff661
Merge branch 'master' into base/update-slider-unstyled
mnajdova d7607ed
add handlers in the callback for the props
mnajdova 625e62d
Merge branch 'base/update-slider-unstyled' of https://github.com/mnaj…
mnajdova d81b1c8
Remove unused imports
mnajdova 662f1cd
Michal's review
mnajdova cc5e511
Merge branch 'master' into base/update-slider-unstyled
mnajdova 80fd507
Update the conformance test, remove getTrackProps usages
mnajdova 967978a
Spread trackStyle
mnajdova 3cf779a
Various fixes
mnajdova 97ca246
Merge branch 'master' into base/update-slider-unstyled
mnajdova 52e5a7c
Address review comments
mnajdova afac9ca
Improve onMouseDown handling
mnajdova 9f83569
Refactor event handlers
mnajdova ebab422
Merge branch 'master' into base/update-slider-unstyled
mnajdova d556c51
Fixes after merge
mnajdova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
component
prop should remain in the docs, shouldn't it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's removed because the prop is available in the unstyled component. Will double check