Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system] Fix discrepancy between core and system ThemeOptions #30095

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Dec 7, 2021

Fixes #27139.

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 7, 2021

No bundle size changes

Generated by 🚫 dangerJS against 70eccef

@hbjORbj hbjORbj changed the title [types] Fix discrepancy between core and system ThemeOptions [typescript] Fix discrepancy between core and system ThemeOptions Dec 8, 2021
@hbjORbj hbjORbj added bug 🐛 Something doesn't work typescript labels Dec 8, 2021
@fmeum
Copy link
Contributor Author

fmeum commented Dec 9, 2021

The CI failures look unrelated at first glance, but I'm not sure. @hbjORbj Can you provide some guidance?

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for taking care of it. Was tested in https://github.com/fmeum/mui-reproducer

@mnajdova mnajdova changed the title [typescript] Fix discrepancy between core and system ThemeOptions [system] Fix discrepancy between core and system ThemeOptions Dec 10, 2021
@hbjORbj
Copy link
Member

hbjORbj commented Dec 10, 2021

@fmeum Thank you for your contribution. I simply had to click "Details" and do "Re-run from failed" :)

@hbjORbj hbjORbj merged commit 4b440e3 into mui:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createTheme throwing type errors with typescript
4 participants