Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Try converting packages to ESM #30510

Closed
wants to merge 14 commits into from
Closed

Draft: Try converting packages to ESM #30510

wants to merge 14 commits into from

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 5, 2022

Investigating #28628

package: https://pkg.csb.dev/mui-org/material-ui/commit/9be0f0dd/@mui/material

To Do:

@Janpot Janpot changed the title Canary: convert to ESM Draft: Try converting packages to ESM Jan 5, 2022
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 5, 2022

Details of bundle changes

Generated by 🚫 dangerJS against beb6c86

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 8, 2022
@mui-bot
Copy link

mui-bot commented Jul 8, 2022

Netlify deploy preview

https://deploy-preview-30510--material-ui.netlify.app/

@material-ui/core: parsed: +0.09% , gzip: +0.11%
@material-ui/lab: parsed: +0.17% , gzip: +0.18%
@material-ui/unstyled: parsed: +0.53% , gzip: +0.53%
@material-ui/utils: parsed: +3.85% , gzip: +3.71%
@mui/material-next: parsed: +0.29% , gzip: +0.32%
@mui/joy: parsed: +0.11% , gzip: +0.20%

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 944f511

@wight554
Copy link

https://github.com/sheremet-va/dual-packaging might be helpful
I guess it's possible to integrate it in non-major release w/o breaking changes by keeping package cjs with proper esm exports

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 20, 2022
@zannager zannager added the package: material-ui Specific to @mui/material label Nov 21, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 21, 2022
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 27, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 13, 2023
@Janpot
Copy link
Member Author

Janpot commented Mar 21, 2024

Superseded by #41102

@Janpot Janpot closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: material-ui Specific to @mui/material PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants