Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joy] Add SvgIcon component #30570

Merged
merged 15 commits into from Jan 13, 2022
Merged

[Joy] Add SvgIcon component #30570

merged 15 commits into from Jan 13, 2022

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Jan 10, 2022 •
edited

Summary
Mostly replicate material SvgIcon component with some tweaks to adapt to Joy package:

@hbjORbj hbjORbj added component: SvgIcon The React component. package: joy-ui Specific to @mui/joy labels Jan 10, 2022
@hbjORbj hbjORbj changed the title Draft: [Joy] Add SvgIcon component Draft: [Joy] Add SvgIcon component Jan 10, 2022
@mui-pr-bot
Copy link

Bundle size will be reported once CircleCI build #336185 finishes.

Generated by 🚫 dangerJS against 283baba

@mui-bot
Copy link

mui-bot commented Jan 12, 2022 •
edited

Details of bundle changes

@mui/joy: parsed: +2.23% , gzip: +1.78%

Generated by 🚫 dangerJS against a459744

@hbjORbj hbjORbj changed the title Draft: [Joy] Add SvgIcon component [Joy] Add SvgIcon component Jan 12, 2022
@hbjORbj hbjORbj requested review from siriwatknp, danilo-leal and mnajdova and removed request for siriwatknp January 12, 2022 07:57
siriwatknp
siriwatknp approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Niceee, thanks Benny!

danilo-leal
danilo-leal approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, Benny!

@hbjORbj hbjORbj merged commit b9120c1 into mui:master Jan 13, 2022
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
@hbjORbj @wladimirguerra
[Joy] Add SvgIcon component (mui#30570)
b9d4190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@danilo-leal danilo-leal danilo-leal approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: SvgIcon The React component. package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hbjORbj @mui-pr-bot @mui-bot @siriwatknp @danilo-leal