[DatePicker] Added disabled property and example #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @andrejunges Please could you put the example in ExampleSimple (just convention to have diabled examples there), and update the description in Page.jsx? |
|
Could you also set |
oliviertassinari
added
PR: needs revision
|
yep, will do that soon |
andrejunges
force-pushed
the
master
branch
2 times, most recently
from
758b3a4
to
698186d
Compare
|
any other suggestion? @mbrookes @oliviertassinari |
|
Just this:
|
|
something like that @mbrookes ? |
| @@ -17,7 +17,8 @@ import datePickerExampleInternationalCode from '!raw!./ExampleInternational'; | |||
| import datePickerReadmeText from './README'; | |||
|
|
|||
| const descriptions = { | |||
| simple: 'The Date Picker defaults to a portrait dialog. The `mode` property can be set to `landscape`.', | |||
| simple: 'The Date Picker defaults to a portrait dialog. The `mode` property can be set to `landscape`. You can ' + | |||
| 'also disable the Dialog passing `true` to the property `disabled`.', | |||
There was a problem hiding this comment.
Looks good. I think "to the disabled property." might read better. (Minor nitpick!)
|
done :) |
mbrookes
added
PR: Review Accepted
and removed
PR: needs revision
|
Looks good to me. |
oliviertassinari
added a commit
that referenced
this pull request
Jan 29, 2016
[DatePicker] Added disabled property and example
|
@andrejunges Thanks! |
zannager
added
component: date picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.