Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Fix code button with installation command #30622

Merged
merged 3 commits into from Jan 17, 2022

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Jan 14, 2022

Hopefully fixes #30585.

  • The installation command is now complete, with all dependencies. If you copy and paste it into your project, it will install MUI Material correctly. It wasn't the case previously.
  • The Get started button now directs to the Installation page instead of the Usage.

https://deploy-preview-30622--material-ui.netlify.app/

@danilo-leal danilo-leal added the website Pages that are not documentation-related, marketing-focused. label Jan 14, 2022
@mui-bot
Copy link

mui-bot commented Jan 14, 2022

No bundle size changes

Generated by 🚫 dangerJS against 1ac7ada

@danilo-leal
Copy link
Contributor Author

A question I have though: due to the limited space and me not wanting to break the overall layout (two buttons in a row), the command is not entirely visible (even though it is copied in its entirety when the button is clicked). Could that be a problem or a confusing thing?

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

I don't know how the commits regarding the logo improvements ended up in this PR... Reversing them.
@danilo-leal danilo-leal mentioned this pull request Jan 17, 2022
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Get Started link target is definitely an improvement! 👍

As for the installation command, I liked the previous version better, but it's nowhere near a hill I'm willing to die on ;)

@danilo-leal danilo-leal merged commit 9f7cd90 into mui:master Jan 17, 2022
@danilo-leal danilo-leal deleted the fix-code-button branch January 17, 2022 19:03
@oliviertassinari
Copy link
Member

It seems to introduce another problem:

https://deploy-preview-30622--material-ui.netlify.app/

Screenshot 2022-01-31 at 22 03 21

@danilo-leal
Copy link
Contributor Author

I've addressed it in #30828.

wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
@oliviertassinari
Copy link
Member

@danilo-leal Great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The website's install command example is incomplete
5 participants