[Examples] Upgrade for the new format #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
| @@ -1,7 +1,7 @@ | |||
| import React from 'react'; | |||
| import ReactDOM from 'react-dom'; | |||
| import injectTapEventPlugin from 'react-tap-event-plugin'; | |||
| import Main from './components/main'; // Our custom react component | |||
| import Main from './main'; // Our custom react component | |||
|
Thanks a lot @oliviertassinari 👍 👍 |
I have forgotten to take into account the examples in my lastet PR to use getMuiTheme. I though it was a good opportunity to clean our examples. I have: - Remove the component folder - Remove the `_` for the method handlers - Fix the usage of `getMuiTheme` - Use the `themeDecorator` to provide the theme. - Upgraded theme to ES6 classes I'm convinced that it's should be the only way that we should document
|
I'm going ahead 💯. |
oliviertassinari
added a commit
that referenced
this pull request
Jan 28, 2016
[Examples] Upgrade for the new format
|
Thanks 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have forgotten to take into account the examples in my latest PR to use
getMuiTheme(#3076).I thought it was a good opportunity to clean our examples.
I have:
/componentsfolder_for the method handlersgetMuiThemethemeDecoratorto provide themuiThemecontext.I'm convinced that it's should be the only way that we should document it.