New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] Add extending OutlinedInputProps
by SelectProps
#31209
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I think adding notched?: boolean
to the SelectProps
interface should be enough (no need to extend the OutlinedInputProps
again because it extends StandardProps
).
Also, please add type test to Select.spec.tsx
to make sure that it is working.
I see your point, however, according to docs If OutlinedInput props were ever to change, then Select props would fall out of sync. I see that now only Let me know what you think and I'll add tests in meantime. |
OutlinedInputProps
by SelectProps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 truly appreciate your contribution!
Yep, you are right about it. Thanks for clarifying. |
Closes #31208
According to docs Select should have OutlineInput props available. Functionality works, but typescript coverage was lacking.