Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-next] Mark @mui/material as a dependency #31270

Merged
merged 1 commit into from Mar 3, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 2, 2022

Without @mui/material as a dependency in @mui/material-next, this error could happen in any PRs. The fix allows lerna to organize the build order for us.

Screen Shot 2565-03-02 at 09 24 48

Source: https://app.circleci.com/pipelines/github/mui/material-ui/65801/workflows/aebea217-a369-486e-83e0-452db3ff7c20/jobs/355054


@mui-bot
Copy link

mui-bot commented Mar 2, 2022

No bundle size changes

Generated by 🚫 dangerJS against c9ccb59

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! material-next still depends on material, so it should be in dependencies indeed.

@siriwatknp siriwatknp merged commit 4430776 into mui:master Mar 3, 2022
@oliviertassinari oliviertassinari added package: material-ui Specific to @mui/material v6.x labels Sep 17, 2022
@DiegoAndai DiegoAndai added v7.x and removed v6.x labels Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: material-ui Specific to @mui/material v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants