Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add banner in solidarity with Ukraine #31275

Merged
merged 8 commits into from Mar 3, 2022

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Mar 2, 2022

Let me know any improvement to the writing or anything else.
Preview: https://deploy-preview-31275--material-ui.netlify.app/getting-started/installation/

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Mar 2, 2022
@mui-bot
Copy link

mui-bot commented Mar 2, 2022

No bundle size changes

Generated by 🚫 dangerJS against a3616b9

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it would be great to show the Ukrainian flag, somewhere, this would be very clear.

docs/src/components/banner/TableOfContentsBanner.tsx Outdated Show resolved Hide resolved
docs/src/components/banner/TableOfContentsBanner.tsx Outdated Show resolved Hide resolved
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 2, 2022

There is a visual bug. Also, is the yellow expected?

Screen Shot 2021-07-09 at 19 48 48

@danilo-leal
Copy link
Contributor Author

danilo-leal commented Mar 2, 2022

@oliviertassinari

There is a visual bug.

It was solved in the most recent commit but for some reason, Netlify is taking too much time to update the Preview link...

Also, is the yellow expected?

Well, I guess you didn't notice 😅 But it is the creative solution I mentioned above: I've created the Ukraine flag within the TOC banner to avoid using the emoji (only available on macOS, as you've pointed out).

@michaldudak
Copy link
Member

IMO a flag image would work better.
But aside from that, I think it's important to publish it soon. So let's merge and publish it as soon as possible and then improve if needed.

@danilo-leal
Copy link
Contributor Author

a flag image would work better.

Yup, followed your suggestion! I think we're ready to go now.

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danilo-leal danilo-leal merged commit 48627ab into mui:master Mar 3, 2022
@danilo-leal danilo-leal deleted the mui-position-ukraine branch March 3, 2022 13:42
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 3, 2022

It was solved in the most recent commit but for some reason, Netlify is taking too much time to update the Preview link...

@danilo-leal Arf, right. For what's worth, I have been exploring how to solve this problem (faster deploy) for the last two weeks 😁

I've created the Ukraine flag within the TOC banner

Oh right, I think that the first "mind blocker“ for me was the non-proportional height of the two horizontal bars. With equal height, I think that I would have started to visualize the reference.

@danilo-leal
Copy link
Contributor Author

Oh right, I think that the first "mind blocker“ for me was the non-proportional height of the two horizontal bars. With equal height, I think that I would have started to visualize the reference.

Hopefully, it's way clearer now!

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 3, 2022

Hopefully, it's way clearer now!

@danilo-leal yes, very clear 👌


If we get feedback like facebook/create-react-app#12113 (comment) (which I can understand), then I think that we should scope the message to only browsers that have Russian as an accepted language. It would approximate https://inews.co.uk/news/un-vote-ukraine-russia-countries-abstained-general-assembly-result-resolution-explained-1495346 well.

@mbrookes mbrookes changed the title [docs] Add banner in solidarity of Ukraine [docs] Add banner in solidarity with Ukraine Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants