New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add banner in solidarity with Ukraine #31275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it would be great to show the Ukrainian flag, somewhere, this would be very clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
It was solved in the most recent commit but for some reason, Netlify is taking too much time to update the Preview link...
Well, I guess you didn't notice 😅 But it is the creative solution I mentioned above: I've created the Ukraine flag within the TOC banner to avoid using the emoji (only available on macOS, as you've pointed out). |
IMO a flag image would work better. |
Yup, followed your suggestion! I think we're ready to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@danilo-leal Arf, right. For what's worth, I have been exploring how to solve this problem (faster deploy) for the last two weeks 😁
Oh right, I think that the first "mind blocker“ for me was the non-proportional height of the two horizontal bars. With equal height, I think that I would have started to visualize the reference. |
Hopefully, it's way clearer now! |
@danilo-leal yes, very clear 👌 If we get feedback like facebook/create-react-app#12113 (comment) (which I can understand), then I think that we should scope the message to only browsers that have Russian as an accepted language. It would approximate https://inews.co.uk/news/un-vote-ukraine-russia-countries-abstained-general-assembly-result-resolution-explained-1495346 well. |
Let me know any improvement to the writing or anything else.
Preview: https://deploy-preview-31275--material-ui.netlify.app/getting-started/installation/