[Joy] Add --Icon-fontSize to components
#31360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mui/joy: parsed: +0.64% , gzip: +0.33% |
siriwatknp
commented
Mar 8, 2022
| @@ -59,9 +59,9 @@ export default function JoyTypography() { | |||
| }} | |||
| > | |||
| <Input placeholder="Placeholder" /> | |||
| <Input placeholder="Placeholder" startAdornment={<Mail fontSize="lg" />} size="sm" /> | |||
There was a problem hiding this comment.
With the adaptable icon, we don't need to force the fontSize anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃枼 Preview
A follow-up PR from #31268 to let other components that usually contain Icon as a child control the icon font-size.
Also, fix some components that do not define variables for each size.