-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stepper] Export useStepperContext #31398
Conversation
@danilo-leal are you able to kick off or ask someone to kick off the workflows at least, please? 😬 |
fd45662
to
2a22b51
Compare
Hi. Thanks for opening the pull request. I ran the workflows as you requested. Many CI tests are failing, so please address them first. You will find this guide useful: https://github.com/mui/material-ui/blob/master/CONTRIBUTING.md#how-to-increase-the-chance-of-being-accepted |
5b115be
to
f9725a2
Compare
Hey @hbjORbj , my bad. Copy/paste error. Fixed now and rebased on master. |
Would be awesome to get this into the next release if possible please @hbjORbj |
@eps1lon is it possible to get this reviewed, please? It's been sitting here ready to go for 12d :/ |
Can someone please review this? Apparently argos detected changes (that have nothing to do with the content of this PR)... This has been open for more than a month now... Edit: Looks like argos is ok again. please review and merge if you agree with the proposed changes. |
@mnajdova Would you mind reviewing this PR, please? |
@siriwatknp would you mind reviewing this PR, please? |
Sure, I am reviewing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the contribution and so sorry for the delay. It will be released next week!
Awesome, thanks for getting back to me @siriwatknp, looking forward to being able to use the |
Hey, a great proposal, very convenient! I'm tinkering with an idea of exposing the IK MUI doesn't provide functions to update the const Funnel = () => (
<Stepper activeStep={1}>
<Step>
<StepLabel>Label</StepLabel>
</Step>
</Stepper>
<StepperMethodsProvider>
<StepComponent />
</StepperMethodsProvider>
)
const StepComponent = () => {
const { goToNextPage } = useStepperMethods()
} Is this the idiomatic way to deal with providing the custom |
@Moshyfawn Thanks for the feedback. Can you open a new issue and provide a Code sandbox that replicates what you need? If there are more people upvoting on the issues, we might work on it. Let's discuss first. |
Got it! Thank you for your amazing work! |
Thanks for the merge @michaldudak |
Pretty much a similar PR to #31021 except this one is targeting the
StepperContext
as opposed to theStepContext
.I believe this would close #31277 as it would then expose both contexts that @jedimonkey was looking for (note: I work on the same project as @jedimonkey).
Additional context:
We are using the StepperContext to grab the
activeStep
and compare it tostepContext.index
to return100
or0
progress
value for aLinearProgress
component sitting in between steps.