[Autocomplete] Fix keep listbox open on left/right keys when inputValue is not empty #31407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
the
component: autocomplete
mnajdova
reviewed
Mar 23, 2022
| @@ -474,6 +474,28 @@ describe('<Autocomplete />', () => { | |||
| expect(textbox).toHaveFocus(); | |||
| }); | |||
|
|
|||
| it('should keep listbox open on pressing left or right keys when inputValue is not empty', () => { | |||
There was a problem hiding this comment.
Can we also add test that will test that the listbox is closed if the input value is empty?
mnajdova
reviewed
Mar 23, 2022
| @@ -682,7 +682,9 @@ export default function useAutocomplete(props) { | |||
| return; | |||
| } | |||
|
|
|||
| handleClose(event, 'toggleInput'); | |||
| if (inputValue === '') { | |||
mnajdova
approved these changes
May 3, 2022
There was a problem hiding this comment.
Thanks @alisasanib for the contribution. Sorry it took me some time to get to it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #31083
Code sandbox demo
Problem:
The list is closed upon clicking the ArrowLeft and ArrowRight key buttons if the user wants to move the cursor on the input value text.
Solution:
Adding a condition before closing the listbox, in order to check if the input value is not empty or not.