[Fab] Make the color prop type extendable
#31830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paales
commented
Mar 16, 2022
paales
commented
- I have followed (at least) the PR section of the contributing guide.
danilo-leal
changed the title
Input, Fab, and Joy's SvgIcon color prop extendable
danilo-leal
added
component: text field
github-actions
bot
added
the
PR: out-of-date
|
almost made a similar PR! |
mnajdova
reviewed
May 18, 2022
| @@ -358,7 +358,10 @@ Input.propTypes /* remove-proptypes */ = { | |||
| * The color of the component. It supports those theme colors that make sense for this component. | |||
| * The prop defaults to the value (`'primary'`) inherited from the parent FormControl component. | |||
| */ | |||
| color: PropTypes.oneOf(['error', 'info', 'primary', 'secondary', 'success', 'warning']), | |||
| color: PropTypes /* @typescript-to-proptypes-ignore */.oneOfType([ | |||
There was a problem hiding this comment.
Note this is in an experimental package, is not the @mui/material one :)
mnajdova
changed the title
Input, Fab, and Joy's SvgIcon color prop extendablecolor prop type extendable
github-actions
bot
removed
the
PR: out-of-date
|
Thank you! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.