Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Revise Showcase copy for clarity + audit appList #31946

Merged
merged 14 commits into from May 10, 2022

Conversation

samuelsycamore
Copy link
Member

@samuelsycamore samuelsycamore commented Mar 22, 2022

This PR follows up on the conversation from #31942, bringing more clarity to the Showcase page.

https://deploy-preview-31946--material-ui.netlify.app/discover-more/showcase/

Additionally, the copy shifts the branding away from MUI as a product to MUI as a company with a suite of products. While the text is not technically true today—we only have one component library as I'm writing this—I think this is acceptable given the imminent release of Base, plus it makes the copy more future-proof so it won't need to be updated again anytime soon.

Screen Shot 2022-03-22 at 10 19 14 AM

@samuelsycamore samuelsycamore added the docs Improvements or additions to the documentation label Mar 22, 2022
@mui-bot
Copy link

mui-bot commented Mar 22, 2022

Details of bundle changes

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Generated by 🚫 dangerJS against 6edd3df

@danilo-leal
Copy link
Contributor

I guess that in order to have this new copy live, we should probably check whether the projects we currently have match our requirements. I'm sure that there are a bunch there that don't.

@samuelsycamore
Copy link
Member Author

That is a good point @danilo-leal. Do you think that auditing the current listings should be a part of this PR, or should that be a separate issue?

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
@danilo-leal
Copy link
Contributor

Making the auditing part of this PR will probably be safer in terms of making sure the content is following what we required... But doing it separately would also work, just a matter of coordinating them I guess.

@samuelsycamore
Copy link
Member Author

I reviewed all sites listed and removed those that were broken, outdated, or apparently no longer using Material UI.

What do we think about super old apps on the list using < v5? I found a couple v1 examples, not sure whether they're worth keeping for the historical record. 😛

@samuelsycamore samuelsycamore changed the title [docs] Revise Showcase copy for clarity [docs] Revise Showcase copy for clarity + audit appList Mar 24, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 25, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 1, 2022
@samuelsycamore
Copy link
Member Author

I completely forgot about this PR—could've sworn it was already merged! 😅

@samuelsycamore samuelsycamore requested a review from a team April 28, 2022 14:52
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@samuelsycamore samuelsycamore merged commit 0dad28e into mui:master May 10, 2022
@samuelsycamore samuelsycamore deleted the update-showcase-copy branch April 3, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants